[PATCH] D154858: [WIP] [AMDGPU] Add llvm.amdgcn.reduce.add Intrinsic.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SILowerReduceAndScanPseudo.cpp:172
+
+bool SIExpandReduceAndScanPseudo::runOnMachineFunction(MachineFunction &MF) {
+
----------------
pravinjagtap wrote:
> arsenm wrote:
> > This doesn't need to be a separate pass, can be a post isel hook 
> Are you referring to `EmitInstrWithCustomInserter` API where other PSEUDOs are expanded ?
Yes, that's generally where the pseudos to hack around the DAG not handling control flow go


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154858/new/

https://reviews.llvm.org/D154858