[PATCH] D154854: Use empty symbol name for XCOFF text csect

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 11 16:43:47 PDT 2023


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-text.ll:2
+; RUN: llc -filetype=obj --function-sections -mtriple powerpc-ibm-aix-xcoff -o %t.o < %s
+; RUN: llvm-objdump --syms %t.o | FileCheck %s
+; RUN: llc -filetype=obj --function-sections -mtriple powerpc64-ibm-aix-xcoff -o %t64.o < %s
----------------
hubert.reinterpretcast wrote:
> Since this is a new test, I think we should use `--symbol-description` (same for other case below).
@stephenpeckham, while the case where `text()` is defined needs `function-sections` to exhibit the failure, there is another case where `text()` is an external reference that does not need `function-sections`.

I suggest adding that additional test as well.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154854/new/

https://reviews.llvm.org/D154854



More information about the llvm-commits mailing list