[PATCH] D154972: [amdgpu][lds] Fix missing markUsedByKernel calls and undef lookup table elements

[Jon Chesterfield via Phabricator via llvm-commits]

JonChesterfield added a comment.

In D154972#4491717 <https://reviews.llvm.org/D154972#4491717>, @arsenm wrote:

> Add the fixes # thing to the commit message so it gets auto closed

Good call, thanks!



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp:515
         ArrayType::get(KernelOffsetsType, NumberKernels);
 
+    Constant *Missing = PoisonValue::get(KernelOffsetsType);
----------------
One segv was here. This is assigning an array element for each kernel in OrderedKernels, where some might not have a corresponding kernel struct


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154972/new/

https://reviews.llvm.org/D154972