[PATCH] D154665: fixed invalid symbol handling in ELFObjectFile::getSymbolName

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

I made a suggestion to the test. The title probably should use a tag like `[Object] `



================
Comment at: llvm/test/tools/llvm-objdump/ELF/section-symbols.test:16
 # CHECK-NEXT: warning: '[[FILE]]': invalid section index: 68
+# CHECK-DISAS: warning: '[[FILE]]': invalid section index: 67
 
----------------
This check separates `CHECK` for another RUN line.
I suggest that we move `llvm-objdump` and `# CHECK-DISAS` after all `CHECK`.

```
## Test that we consume an error in ELFObjectFile<ELFT>::getSymbolName.
# RUN: llvm-objdump -d ...

# CHECK-DISAS: ...
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154665/new/

https://reviews.llvm.org/D154665