[PATCH] D154993: AtomicExpand: Fix expanding atomics into unconstrained FP in strictfp functions

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 11 16:10:03 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:1582
+
+  // FIXME: If FP exceptions are enabled, we should force them off for the loop
+  // for the FP atomics.
----------------
jyknight wrote:
> I'd reword: "If FP exceptions are observable".
> And, FTR, GCC does already do this (and it's required by the spec). So we should actually fix that at some point. :)
Filed https://github.com/llvm/llvm-project/issues/63812


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154993/new/

https://reviews.llvm.org/D154993



More information about the llvm-commits mailing list