[PATCH] D154972: [amdgpu][lds] Fix missing markUsedByKernel calls

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 11 15:58:10 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp:970
+      // codegen in noclobber-barrier
+      if (!LDSUsesInfo.indirect_access[&Func].empty())
+        markUsedByKernel(Builder, &Func, Replacement.SGV);
----------------
The insert-on-not-found behavior of operator[] is evil, avoid using it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154972/new/

https://reviews.llvm.org/D154972



More information about the llvm-commits mailing list