[PATCH] D154925: [MLIR][IR] Rewrite OperationVerifier using worklist
Mehdi AMINI via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 11 15:18:23 PDT 2023
mehdi_amini added inline comments.
================
Comment at: mlir/lib/IR/Verifier.cpp:113
-LogicalResult OperationVerifier::verifyBlock(
- Block &block, SmallVectorImpl<Operation *> &opsWithIsolatedRegions) {
-
+LogicalResult OperationVerifier::verifyPreChildren(Block &block) {
for (auto arg : block.getArguments())
----------------
Can you try to add some doc about all these methods: not only what they do but when do they get invoked (help the reader understand the whole visitation flow).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154925/new/
https://reviews.llvm.org/D154925
More information about the llvm-commits
mailing list