[PATCH] D154665: fixed invalid symbol handling in ELFObjectFile::getSymbolName

Dayann D'almeida via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 11 14:54:39 PDT 2023


JestrTulip updated this revision to Diff 539303.
JestrTulip added a comment.

removed redundant test


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154665/new/

https://reviews.llvm.org/D154665

Files:
  llvm/include/llvm/Object/ELFObjectFile.h


Index: llvm/include/llvm/Object/ELFObjectFile.h
===================================================================
--- llvm/include/llvm/Object/ELFObjectFile.h
+++ llvm/include/llvm/Object/ELFObjectFile.h
@@ -530,10 +530,10 @@
 
   // If the symbol name is empty use the section name.
   if ((*SymOrErr)->getType() == ELF::STT_SECTION) {
-    if (Expected<section_iterator> SecOrErr = getSymbolSection(Sym)) {
-      consumeError(Name.takeError());
+    Expected<section_iterator> SecOrErr = getSymbolSection(Sym);
+    if (SecOrErr)
       return (*SecOrErr)->getName();
-    }
+    return SecOrErr.takeError();
   }
   return Name;
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154665.539303.patch
Type: text/x-patch
Size: 638 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230711/a04dc273/attachment.bin>


More information about the llvm-commits mailing list