[PATCH] D154364: [LTO] Allow library calls to be internalized in freestanding mode

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 11 14:28:49 PDT 2023


efriedma added a comment.

> It's struck me as a bit of a hack; targets are free to change the names of libcalls in TLI or to include additional target-specific ones, and neither would end up in this list. LTO also depends on the accuracy of this list for correctness, since the symbol table of the link must be finalized before LTO codegen begins.

Right.

> It seems like it might be advantageous to provide a more direct way for the linker to query the code generator for this list via the LTO API; the code generator should be able to produce an accurate list from the configuration its provided by LLD.

This makes sense; I'm not sure how hard it would be to implement, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154364/new/

https://reviews.llvm.org/D154364



More information about the llvm-commits mailing list