[PATCH] D154984: [lit] Drop "Script:", make -v and -a imply -vv

Andrzej Warzynski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 11 14:25:00 PDT 2023


awarzynski added a comment.

This is a very nice clean-up, thanks!

I've only skimmed through so far and just wanted to post a quick question about this:

> **Change**: After this patch, there is no "Script:" section

IMO, it would be nice to be able to simply print the `RUN` lines that LIT has collected. Especially for complex tests for which `RUN` lines depend on various CMake flags (to help developing such tests). So, I would keep the "Script" section, but:

- only print it when explicitly requested (with a dedicated flag, e.g. `-print-script`),
- make it default to "collect the RUN lines, print them and exit" (so the tests wouldn't run).

Would this be difficult and would it make sense to you? Or perhaps that's already supported? :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154984/new/

https://reviews.llvm.org/D154984



More information about the llvm-commits mailing list