[PATCH] D123804: [clang] A Unified LTO Bitcode Frontend

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Sorry for extra nitpicking:)

> [clang] A Unified LTO Bitcode Frontend

I think we typically start with a verb and don't capitalize every words, e.g. `[clang] Support Unified LTO Bitcode frontend`

> This means that LKTO mode can be chosen at link [...]

typo: LKTO?

Feel free to incorporate the following to your summary:

  # Compile and link using regular LTO
  clang -flto -funified-lto -fuse-ld=lld foo.c
  
  # Compile and link using ThinLTO
  clang -flto -funified-lto -fuse-ld=lld foo.c
  
  # Link separately, using ThinLTO.
  clang -c -flto -funified-lto foo.c  # -flto={full,thin} are identical in terms of compilation actions
  clang -flto=thin -fuse-ld=lld foo.o
  
  # Link separately, using regular LTO.
  clang -c -flto -funified-lto foo.c
  clang -flto -fuse-ld=lld foo.o



================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4772
 
+
+  bool UnifiedLTO = false;
----------------
One blank line is sufficient.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123804/new/

https://reviews.llvm.org/D123804