[PATCH] D123804: [clang] A Unified LTO Bitcode Frontend

[Matthew Voss via Phabricator via llvm-commits]

ormris added inline comments.


================
Comment at: clang/test/CodeGen/unified-lto-pipeline.c:1
+// RUN: %clang -flto=thin -funified-lto -O2 -c %s -o %t.0
+// RUN: mv %t.0 %t.1
----------------
MaskRay wrote:
> ormris wrote:
> > MaskRay wrote:
> > > Without `--target`, this uses the default target triple which may fail for some exotic platforms.
> > > 
> > > Prefer `%clang_cc1` for non-driver tests. Instead of comparing the output files, test `-fdebug-pass-manager` output.
> > Why test the pipeline rather than binary equivalence? Identical bitcode files is a key part of this feature.
> `cmp %t.0 %t.1` should be retained. My point is that we probably should test some output to demonstrate that his is a ThinLTO pipeline.
> 
> `// RUN: not cmp %t.2 %t.3` is probably less useful if we can demonstrate that the pipeline is different.
Ah that makes sense. Fixed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123804/new/

https://reviews.llvm.org/D123804