[PATCH] D154994: IRBuilder: Fix not handling strictfp minnum/maxnum

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D154994#4491020 <https://reviews.llvm.org/D154994#4491020>, @jyknight wrote:

>> Removing the rounding mode arguments seems like more trouble than
>> it's worth.
>
> Change looks fine, but I don't understand what you mean by this commit messsage.

The signature of the constrained minnum/maxnum intrinsics is different from other binary operators simply because it doesn't read the rounding mode. It would be easier and could reuse the existing binary operator function if it had the unused operand


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154994/new/

https://reviews.llvm.org/D154994