[PATCH] D154993: AtomicExpand: Fix expanding atomics into unconstrained FP in strictfp functions

[James Y Knight via Phabricator via llvm-commits]

jyknight added inline comments.


================
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:1582
+
+  // FIXME: If FP exceptions are enabled, we should force them off for the loop
+  // for the FP atomics.
----------------
I'd reword: "If FP exceptions are observable".
And, FTR, GCC does already do this (and it's required by the spec). So we should actually fix that at some point. :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154993/new/

https://reviews.llvm.org/D154993