[PATCH] D154717: [LV] Check if ops can safely be truncated in computeMinimumValueSizes.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Analysis/VectorUtils.cpp:676
+            auto *CI = dyn_cast<ConstantInt>(U);
+            // For constants shit amounts, check if the shift would result in
+            // poison.
----------------
nikic wrote:
> shit -> shift :P
A very unfortunate typo, should be fixed in the committed version :) 


================
Comment at: llvm/test/Transforms/LoopVectorize/trunc-shifts.ll:6
 
 ; FIXME: Currently the operands of %l are incorrectly truncated.
 define void @test_pr47927_lshr_const_shift_ops(ptr %dst, i32 %f) {
----------------
nikic wrote:
> Drop FIXME
Thanks, removed in the committed version.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154717/new/

https://reviews.llvm.org/D154717