[PATCH] D154993: AtomicExpand: Fix expanding atomics into unconstrained FP in strictfp functions

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 11 11:26:59 PDT 2023


arsenm created this revision.
arsenm added reviewers: kpn, foad, reames, efriedma, sepavloff, jyknight.
Herald added subscribers: StephenFan, kerbowa, hiraditya, jvesely.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

Ideally the normal fadd/fmin/fmax this was creating would fail the verifier.
It's probably also necessary to force off FP exception handlers in the cmpxchg
loop but we don't have a generic way to do that now.

Note strictfp builder is broken in the minnum/maxnum case


https://reviews.llvm.org/D154993

Files:
  llvm/lib/CodeGen/AtomicExpandPass.cpp
  llvm/lib/Transforms/Utils/LowerAtomic.cpp
  llvm/test/Transforms/AtomicExpand/AMDGPU/expand-atomic-rmw-fadd.ll
  llvm/test/Transforms/AtomicExpand/AMDGPU/expand-atomic-rmw-fmax.ll
  llvm/test/Transforms/AtomicExpand/AMDGPU/expand-atomic-rmw-fmin.ll
  llvm/test/Transforms/AtomicExpand/AMDGPU/expand-atomic-rmw-fsub.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154993.539208.patch
Type: text/x-patch
Size: 60815 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230711/1406c003/attachment-0001.bin>


More information about the llvm-commits mailing list