[PATCH] D154394: [PowerPC] Add DFP conversion instructions definitions and MC tests

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 11 10:27:07 PDT 2023


amyk added a comment.

Just a comment regarding indentation but otherwise I think LGTM, too.



================
Comment at: llvm/lib/Target/PowerPC/PPCInstrDFP.td:94
+defm DCTDP: XForm_26r<59, 258, (outs f8rc:$RST), (ins f8rc:$RB),
+                         "dctdp", "$RST, $RB", IIC_FPGeneral, []>;
+defm DCTQPQ: XForm_26r<63, 258, (outs fpairrc:$RST), (ins f8rc:$RB),
----------------
Could we fix the indentation on the second lines of each instruction definition?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154394/new/

https://reviews.llvm.org/D154394



More information about the llvm-commits mailing list