[PATCH] D154986: [X86] Complete preservation of !pcsections in X86ISelLowering

[Marco Elver via Phabricator via llvm-commits]

melver created this revision.
melver added a reviewer: dvyukov.
Herald added subscribers: pengfei, hiraditya.
Herald added a project: All.
melver requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

https://reviews.llvm.org/D130883 introduced MIMetadata to simplify
metadata propagation (DebugLoc and PCSections).

However, we're currently still permitting implicit conversion of
DebugLoc to MIMetadata, to allow for a gradual transition and let the
old code work as-is.

This manifests in lost !pcsections metadata for X86-specific lowerings.
For example, 128-bit atomics.

Fix the situation for X86ISelLowering by converting all BuildMI() calls
to use an explicitly constructed MIMetadata.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D154986

Files:
  llvm/include/llvm/CodeGen/MachineInstrBuilder.h
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  llvm/lib/Target/X86/X86ISelLowering.cpp
  llvm/test/CodeGen/X86/pcsections-atomics.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154986.539175.patch
Type: text/x-patch
Size: 268659 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230711/99319d13/attachment-0001.bin>