[PATCH] D154067: [NFC][RISCV] Rewrite TableGen files using named arguments

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 11 09:57:36 PDT 2023


MaskRay added a comment.

In D154067#4488114 <https://reviews.llvm.org/D154067#4488114>, @wangpc wrote:

> In D154067#4485978 <https://reviews.llvm.org/D154067#4485978>, @MaskRay wrote:
>
>> Have you tested that the generated `.inc` files do not change?
>
> Juts confirmed that. 
> Theoretically, these changes change nothing but the way to pass arguments. The result `Record`s won't be of any difference so these TableGen backends won't be influenced. :-)

Sounds great! Theoretically `.inc` files shouldn't change. Confirming this is just more confidence that the feature is correctly implemented:)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154067/new/

https://reviews.llvm.org/D154067



More information about the llvm-commits mailing list