[PATCH] D154943: [ARM] Restructure MOVi32imm expansion to not do pointless instructions

Ties Stuij via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 11 08:34:13 PDT 2023


stuij accepted this revision.
stuij added a comment.
This revision is now accepted and ready to land.

very nice :) LGTM, except for inline nit.



================
Comment at: llvm/test/CodeGen/ARM/execute-only.ll:162
+
+  ret i32 287454020
+}
----------------
just a quality of life change to help people reading the test cases, could you replace these base 10 values with their hex literal counterparts:

so: 
`ret i32 u0x11223344`

etc.. for the ones below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154943/new/

https://reviews.llvm.org/D154943



More information about the llvm-commits mailing list