[PATCH] D154941: [mlir][ArmSME] Add custom get_tile_id and cast ops

[Cullen Rhodes via Phabricator via llvm-commits]

c-rhodes marked an inline comment as done.
c-rhodes added a comment.

In D154941#4489650 <https://reviews.llvm.org/D154941#4489650>, @WanderAway wrote:

>>> It may be useful to also indicate what is the intended live range of the allocated tile?
>>
>> Sorry could clarify? Not sure exactly what you mean
>
> I wasn't entirely sure when the tile allocated by this will be "deallocated" since I misread the description of D154955 <https://reviews.llvm.org/D154955> earlier, but upon a closer look I realized the tile allocated is valid in the scope of the function. I thought it'd be a good idea to make this clear in the description (and also how one probably wouldn't be able to pass this as an argument to another function call)

Yes that's right the scope is a function, we could add a deallocation op to free up tiles within functions and also support spilling/filling to memory instead of throwing a "ran out of tiles" error in the future. I'll fix the description to capture what you raised. Cheers.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154941/new/

https://reviews.llvm.org/D154941