[PATCH] D154825: [InstCombine][NFC] Rename check run label

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM -- The described file check behavior seems very weird to me, but changing the prefix doesn't hurt either.



================
Comment at: llvm/test/Transforms/InstCombine/unreachable-code.ll:146
 ; CHECK-SAME: (i32 [[X:%.*]]) {
 ; CHECK-NEXT:    switch i32 -1, label [[DEFAULT:%.*]] [
 ; CHECK-NEXT:    i32 0, label [[CASE0:%.*]]
----------------
piotr wrote:
> Part of this line contains a substring that could potentially be matched with the check run line "DEFAULT:".
> 
Is that intentional FileCheck behavior rather than a bug? It seems pretty odd to me that a check prefix would get matched inside a placeholder declaration of a different check prefix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154825/new/

https://reviews.llvm.org/D154825