[PATCH] D154973: [FPEnv] Update comment about nofpexcept default. NFC

Luke Lau via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 11 07:53:16 PDT 2023


luke created this revision.
luke added reviewers: craig.topper, uweigand, andrew.w.kaylor.
Herald added subscribers: asb, pmatos.
Herald added a project: All.
luke requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

It no longer defaults to false as of 63336795f0d5 <https://reviews.llvm.org/rG63336795f0d50a009e8ec034d95811170efc978b>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D154973

Files:
  llvm/include/llvm/CodeGen/SelectionDAGNodes.h


Index: llvm/include/llvm/CodeGen/SelectionDAGNodes.h
===================================================================
--- llvm/include/llvm/CodeGen/SelectionDAGNodes.h
+++ llvm/include/llvm/CodeGen/SelectionDAGNodes.h
@@ -392,8 +392,8 @@
   // We assume instructions do not raise floating-point exceptions by default,
   // and only those marked explicitly may do so.  We could choose to represent
   // this via a positive "FPExcept" flags like on the MI level, but having a
-  // negative "NoFPExcept" flag here (that defaults to true) makes the flag
-  // intersection logic more straightforward.
+  // negative "NoFPExcept" flag here makes the flag intersection logic more
+  // straightforward.
   bool NoFPExcept : 1;
   // Instructions with attached 'unpredictable' metadata on IR level.
   bool Unpredictable : 1;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154973.539103.patch
Type: text/x-patch
Size: 825 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230711/34ff6b82/attachment.bin>


More information about the llvm-commits mailing list