[PATCH] D154941: [mlir][ArmSME] Add custom get_tile_id and cast ops

[Cullen Rhodes via Phabricator via llvm-commits]

c-rhodes marked an inline comment as done.
c-rhodes added a comment.

In D154941#4489283 <https://reviews.llvm.org/D154941#4489283>, @WanderAway wrote:

> LGTM % a few minor details. Great work!

thanks for taking a look!



================
Comment at: mlir/include/mlir/Dialect/ArmSME/IR/ArmSME.td:54
+def nxnxv2i64  : SMETileType<I64,  [2,  2 ], "vector<[2]x[2]xi64">;
+def nxnxv1i128 : SMETileType<I128, [1,  1 ], "vector<[1]x[1]xi128">;
+
----------------
WanderAway wrote:
> What about `f32` and `f64`?
> What about `f32` and `f64`?

Thanks for pointing that out, I've also added F16/BF16.


================
Comment at: mlir/include/mlir/Dialect/ArmSME/IR/ArmSME.td:188
+    ```
+  }];
+
----------------
WanderAway wrote:
> It may be useful to also indicate what is the intended live range of the allocated tile?
> It may be useful to also indicate what is the intended live range of the allocated tile?

Sorry could clarify? Not sure exactly what you mean


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154941/new/

https://reviews.llvm.org/D154941