[PATCH] D154970: [NFC][AMDGPULowerModuleLDSPass] Factorize repetead sort code
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 11 07:38:27 PDT 2023
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp:249
+template <typename T> std::vector<T> sortByName(std::vector<T> &&V) {
+ llvm::sort(V.begin(), V.end(), [](const auto *L, const auto *R) {
+ return L->getName() < R->getName();
----------------
The danger of anonymous values may require a stable_sort (or do we error on those here, I forget)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154970/new/
https://reviews.llvm.org/D154970
More information about the llvm-commits
mailing list