[PATCH] D154937: [InstCombine] Generalize foldAndOrOfICmpEqZeroAndICmp

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 11 07:28:38 PDT 2023


nikic added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/and-or-icmp-const-icmp.ll:160
   %sub = add <2 x i8> %x, <i8 -5, i8 -5>
   %c1 = icmp ne <2 x i8> %x, <i8 5, i8 5>
   %c2 = icmp ule <2 x i8> %sub, %y
----------------
As you're using m_APIntAllowUndef now, I'd suggest to also add a "splat with undef" vector test like `<i8 5, i8 undef>` here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154937/new/

https://reviews.llvm.org/D154937



More information about the llvm-commits mailing list