[PATCH] D154594: Add version comparison in BooleanExpression for lit testing

[David Stuttard via Phabricator via llvm-commits]

dstuttard added a comment.

I think it would be quite an invasive change to apply substitutions to lines other than RUN

It would require the following changes:
REQUIRES, UNSUPPORTED etc are dealt with during the parseIntegratedTestScript phase at the moment - that would have to change (increasing execution time - and may surface some issues).
REQUIRES etc are global - whereas substitutions are not - and can be changed as the script runs. What version of the substitution should apply, I guess it could be the context of the actual REQUIRES/UNSUPPORTED  (this would require more significant changes to the file though as these would require tracking in the same way as RUN and DEFINE/REDEFINE etc).

I'm not that familiar with this codebase, so I might be wrong.

I could add the ability to compare strings to the current implementation if you are prepared to accept the available_versions addition instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154594/new/

https://reviews.llvm.org/D154594