[PATCH] D154937: [InstCombine] Generalize foldAndOrOfICmpEqZeroAndICmp

[Dhruv Chawla via Phabricator via llvm-commits]

0xdc03 marked 4 inline comments as done.
0xdc03 added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/and-or-icmp-const-icmp.ll:84
 ;
   %sub = sub i8 %x, 5
   %c1 = icmp eq i8 %x, 6
----------------
nikic wrote:
> Write this in canonical form (add -5) or drop the test if redundant with the next.
I was aiming for the signs to be opposite in them, dunno if that is necessary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154937/new/

https://reviews.llvm.org/D154937