[PATCH] D154939: [TableGen] Deprecate old GI Combiner Emitter

[Pierre van Houtryve via Phabricator via llvm-commits]

Pierre-vh updated this revision to Diff 538999.
Pierre-vh added a comment.

Also fix docs while I'm at it. I was thinking of doing another patch but I think it's better to do it all at once.

I'm wondering if the deprecation warning is enough. a CI buildbot will probably ignore them, so downstream users could easily miss it unless they catch it by luck.
Should we add something like "legacy" to the older option? This would make it impossible to miss downstream. They'll have to fix the builds by adding the "legacy" prefix/suffix to the option.
This may be a bit aggressive though, not sure what others think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154939/new/

https://reviews.llvm.org/D154939

Files:
  llvm/docs/CommandGuide/tblgen.rst
  llvm/utils/TableGen/GICombinerEmitter.cpp


Index: llvm/utils/TableGen/GICombinerEmitter.cpp
===================================================================
--- llvm/utils/TableGen/GICombinerEmitter.cpp
+++ llvm/utils/TableGen/GICombinerEmitter.cpp
@@ -1019,6 +1019,10 @@
 //===----------------------------------------------------------------------===//
 
 static void EmitGICombiner(RecordKeeper &RK, raw_ostream &OS) {
+  PrintWarning(
+      "'-gen-global-isel-combiner' is deprecated and will be removed soon; "
+      "please use '-gen-global-isel-combiner-match-table' instead");
+
   CodeGenTarget Target(RK);
   emitSourceFileHeader("Global Combiner", OS);
 
Index: llvm/docs/CommandGuide/tblgen.rst
===================================================================
--- llvm/docs/CommandGuide/tblgen.rst
+++ llvm/docs/CommandGuide/tblgen.rst
@@ -507,11 +507,17 @@
 
 .. option:: -gen-global-isel-combiner
 
-  Generate GlobalISel combiner.
+  (Deprecated, pending removal)
+  Generate legacy GlobalISel combiner.
+
+.. option:: -gen-global-isel-combiner-matchtable
+
+  Generate MatchTable-based GlobalISel combiner.
 
 .. option:: -combiners=list
 
-  Make -gen-global-isel-combiner emit the specified combiners.
+  Make -gen-global-isel-combiner and -gen-global-isel-combiner-matchtable
+  emit the specified combiners.
 
 .. option:: -gicombiner-show-expansions
 
@@ -524,8 +530,8 @@
 
 .. option:: -gicombiner-stop-after-parse
 
-  Make -gen-global-isel-combiner stop processing after parsing rules
-  and dump state.
+  Make -gen-global-isel-combiner and -gen-global-isel-combiner-matchtable stop
+  processing after parsing rules and dump state.
 
 .. option:: -gen-instr-info
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154939.538999.patch
Type: text/x-patch
Size: 1655 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230711/93e28e23/attachment.bin>