[PATCH] D148858: ValueTracking: Replace CannotBeNegativeZero

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

Code LGTM.

> It
> mishandles PreserveSign denormal inputs but that's a preexisting
> issue.

Mishandles? Isn't it up to the caller to worry about that?

> strictfp tests are improvements. The test comment suggests these
> folds should not happen, but I think are correct.

Remove this paragraph.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148858/new/

https://reviews.llvm.org/D148858