[PATCH] D151903: [Flang][MLIR][OpenMP][OMPIRBuilder] Use target triple to initialize `IsTargetCodegen` flag

Tue Jul 11 03:15:12 PDT 2023

skatrak marked 2 inline comments as done.
skatrak added a comment.

Thank you for your feedback, Kiran.

In D151903#4467865 <https://reviews.llvm.org/D151903#4467865>, @kiranchandramohan wrote:

> Will there be a change in the LLVM IR generated if the option is set? If so, it might be good to have a test.

I added an OpenMPIRBuilder test to exercise a code path that is dependent on that flag.

> Have a couple of Nit comments regarding name of the flag. LG.

I created D154591 <https://reviews.llvm.org/D154591> to address the confusion with flag names, because the ones we were using didn't describe very well what they represented. I just updated option / MLIR attribute names here to match what was decided there, which should also address your concerns.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151903/new/

https://reviews.llvm.org/D151903