[PATCH] D138883: [SelectionDAG][PowerPC] Memset reuse vector element for tail store

[Ting Wang via Phabricator via llvm-commits]

tingwang added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/memset-tail.ll:195
+; P8-LE-NEXT:    li 4, 16
+; P8-LE-NEXT:    xxswapd 0, 34
+; P8-LE-NEXT:    stxsdx 34, 3, 4
----------------
Will be eliminated by https://reviews.llvm.org/D139193.


================
Comment at: llvm/test/CodeGen/PowerPC/memset-tail.ll:237
 ; P10-BE-NEXT:    xxspltib 0, 15
+; P10-BE-NEXT:    mffprd 4, 0
 ; P10-BE-NEXT:    stxv 0, 0(3)
----------------
Plan to address this pattern in separate patch.


================
Comment at: llvm/test/CodeGen/PowerPC/memset-tail.ll:246
+; P8-LE-NEXT:    li 4, 15
+; P8-LE-NEXT:    xxswapd 0, 34
+; P8-LE-NEXT:    stxsdx 34, 3, 4
----------------
Will be eliminated by https://reviews.llvm.org/D139193.


================
Comment at: llvm/test/CodeGen/PowerPC/memset-tail.ll:261
 ; P10-LE-NEXT:    xxspltib 0, 15
+; P10-LE-NEXT:    mffprd 4, 0
 ; P10-LE-NEXT:    stxv 0, 0(3)
----------------
Plan to address this pattern in separate patch.


================
Comment at: llvm/test/CodeGen/PowerPC/memset-tail.ll:299
+; P8-LE-NEXT:    li 4, 16
+; P8-LE-NEXT:    xxswapd 0, 34
+; P8-LE-NEXT:    stxsiwx 34, 3, 4
----------------
Will be eliminated by https://reviews.llvm.org/D139193.


================
Comment at: llvm/test/CodeGen/PowerPC/memset-tail.ll:353
+; P8-LE-NEXT:    li 4, 15
+; P8-LE-NEXT:    xxswapd 0, 34
+; P8-LE-NEXT:    stxsiwx 34, 3, 4
----------------
Will be eliminated by https://reviews.llvm.org/D139193.


================
Comment at: llvm/test/CodeGen/PowerPC/memset-tail.ll:715
 ; P10-BE-NEXT:    xxspltib 0, 165
+; P10-BE-NEXT:    mffprd 4, 0
 ; P10-BE-NEXT:    stxv 0, 0(3)
----------------
Plan to address this pattern in separate patch.


================
Comment at: llvm/test/CodeGen/PowerPC/memset-tail.ll:739
 ; P10-LE-NEXT:    xxspltib 0, 165
+; P10-LE-NEXT:    mffprd 4, 0
 ; P10-LE-NEXT:    stxv 0, 0(3)
----------------
Plan to address this pattern in separate patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138883/new/

https://reviews.llvm.org/D138883