[PATCH] D152714: [AArch64][Optimization]Solving the FCCMP issue

Tue Jul 11 01:30:46 PDT 2023

samtebbs accepted this revision.
samtebbs added a comment.
This revision is now accepted and ready to land.

Just one small change, but otherwise it looks good to me! I can commit this for you once you've moved the comment above the function, and then we can see about getting you commit access yourself.

================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:16409
+      SDLoc DL(N);
+      // Transform and(fcmp(a, b), fcmp(c, d)) into fccmp(fcmp(a, b), c, d)
+      return DAG.getNode(AArch64ISD::CSINC, DL, VT,
----------------
I think this comment is quite useful and would be good to have on the line above the function definition.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152714/new/

https://reviews.llvm.org/D152714