[PATCH] D154925: [MLIR][IR] Rewrite OperationVerifier using worklist

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 11 01:01:42 PDT 2023


alexander-shaposhnikov created this revision.
alexander-shaposhnikov added reviewers: mehdi_amini, jpienaar.
alexander-shaposhnikov created this object with visibility "All Users".
Herald added subscribers: bviyer, Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle.
Herald added a reviewer: rriddle.
Herald added a project: All.
alexander-shaposhnikov requested review of this revision.
Herald added subscribers: stephenneuendorffer, nicolasvasilache.
Herald added a project: MLIR.

This diff switches OperationVerifier to using a worklist rather than recursion.
This fixes the crash of the "verifier" on the input from https://github.com/llvm/circt/issues/5316 
(but the IR printer would still crash with stack overflow).

Test plan: ninja check-mlir check-all


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D154925

Files:
  mlir/lib/IR/Verifier.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154925.538942.patch
Type: text/x-patch
Size: 9796 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230711/a6e633cd/attachment.bin>


More information about the llvm-commits mailing list