[PATCH] D149860: [TextAPI] Introduce SymbolSet

[Cyndy Ishida via Phabricator via llvm-commits]

cishida added inline comments.


================
Comment at: llvm/lib/TextAPI/Symbol.cpp:68
   SymbolFlags RHSFlags = O.Flags;
-  if ((!O.isData() && !O.isText()) || (!isData() && !isText())) {
-    RemoveFlag(*this, LHSFlags);
-    RemoveFlag(O, RHSFlags);
-  }
+  // Ignore Text and Data for now.
+  RemoveFlag(*this, LHSFlags);
----------------
cishida wrote:
> zixuw wrote:
> > Could you explain more about this change? Is this change related to SymbolSet?
> I needed it to pass tests. This was an attempt to still check a TBD-v5 only attribute against older TBD file formats. Its not very useful or sound so I just removed it. The lambda should be removed too though. 
NVM, I meant the removal is valid to be able to compare older files. Just trying to conditionalize it based off indirect assumptions isn't useful ATM. To be able to do this accurately I'd need to pass `FileType` down to this comparator.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149860/new/

https://reviews.llvm.org/D149860