[PATCH] D154885: [DAGCombiner] Limit graph traversal to cap compile times

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 10 14:34:18 PDT 2023


MaskRay added a comment.

We use a `MaxDepth` pattern in many places, e.g., llvm/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp, several `*ISelLowering.cpp` files, and `SelectionDAG::copyExtraInfo`.

I am curious whether you can come up a pathological case to demonstrate the issue, even if crafting a test is not so practical. Without more information future refactors cannot know how they can be certain this problem has been fixed in the root cause (if there is a way...).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154885/new/

https://reviews.llvm.org/D154885



More information about the llvm-commits mailing list