[PATCH] D154777: [LLD] [COFF] Warn about pseudo relocations that are too narrow

Mateusz MikuĊ‚a via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 10 13:56:39 PDT 2023


mati865 accepted this revision.
mati865 added a comment.
This revision is now accepted and ready to land.

I'm in favor of the warning. I don't know LLVM process for adding new errors for code that was previously accepted (even if wrongly) but IMO new errors should be introduced in a way that doesn't surprisingly break downstreams.
So I'd be okay if this becomes a warning in next release (N) and an error/hard error (don't think LLD threats them differently though) in release N+1 or N+2.

ASs for the tone, dunno, I think even with HEASLR user can be lucky enough to have it working.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154777/new/

https://reviews.llvm.org/D154777



More information about the llvm-commits mailing list