[PATCH] D149860: [TextAPI] Introduce SymbolSet

[Zixu Wang via Phabricator via llvm-commits]

zixuw added inline comments.


================
Comment at: llvm/include/llvm/TextAPI/Symbol.h:73-75
+      lower_bound(Container, Targ, [](const Target &LHS, const Target &RHS) {
+        return LHS < RHS;
+      });
----------------
nit: I think `lower_bound` already uses `operator<` for comparison. Is this needed? Or maybe use `std::less{}`?


================
Comment at: llvm/lib/TextAPI/Symbol.cpp:68
   SymbolFlags RHSFlags = O.Flags;
-  if ((!O.isData() && !O.isText()) || (!isData() && !isText())) {
-    RemoveFlag(*this, LHSFlags);
-    RemoveFlag(O, RHSFlags);
-  }
+  // Ignore Text and Data for now.
+  RemoveFlag(*this, LHSFlags);
----------------
Could you explain more about this change? Is this change related to SymbolSet?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149860/new/

https://reviews.llvm.org/D149860