[PATCH] D147740: [llvm-profdata] Refactoring Sample Profile Reader to increase FDO build speed using MD5 as key to Sample Profile map

[William Junda Huang via Phabricator via llvm-commits]

huangjd added a comment.

In D147740#4485824 <https://reviews.llvm.org/D147740#4485824>, @aeubanks wrote:

> In D147740#4482560 <https://reviews.llvm.org/D147740#4482560>, @huangjd wrote:
>
>> In D147740#4479339 <https://reviews.llvm.org/D147740#4479339>, @aeubanks wrote:
>>
>>> can you repro the previous failure with the alignment sanitizer? then if that goes away with your fix it should be good
>>
>> I built it with `-DLLVM_USE_SANITIZER=Memory` and didn't see any (new) issue on X86, but I don't have a SPARC machine available to test on it. Is there another flag I need to use?
>
> alignment checking is a ubsan thing, not a msan thing, so it should be `-DLLVM_USE_SANITIZER=Undefined`. I believe that should enable alignment checking: https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html#available-checks

That option does not work for me. Note that `-DLLVM_USE_SANITIZER` is an option in CMake configuration, but the list you gave is compiler options. I got the error `cc: error: unrecognized argument to ‘-fno-sanitize=’ option: ‘function’` when `DLLVM_USE_SANITIZER` is set to anything other than `Memory`. Could you show the exact command to build and run all tests with said sanitizer enabled?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147740/new/

https://reviews.llvm.org/D147740