[PATCH] D154876: [Demangle] use std::string_view::data rather than &*std::string_view::begin

Louis Dionne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 10 12:36:37 PDT 2023


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM -- this would fail with libc++ bounded iterators as well, since you might end up dereferencing a past-the-end iterator in case the string is empty.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154876/new/

https://reviews.llvm.org/D154876



More information about the llvm-commits mailing list