[PATCH] D147285: [Support] Extended llvm-profdata's merge functionality to exclude profiles from functions matching configurable patterns

[NILANJANA BASU via Phabricator via llvm-commits]

nilanjana_basu marked an inline comment as done.
nilanjana_basu added inline comments.
Herald added a subscriber: wangpc.


================
Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:1314
 
+    if (!ExcludeFuncs.empty())
+      exitWithError("-exclude-function is not supported with "
----------------
nilanjana_basu wrote:
> Gerolf wrote:
> > The check above is for !SuppInstrWithSample, so this code could issue a wrong error message.
> The check above is for !SupplInstrWithSample.empty(). I don't see how this is a wrong error message, since exclude-function functionality is not supported with the -supplement-instr-with-sample option.
@Gerolf : If I misunderstood the issue, can you elaborate on this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147285/new/

https://reviews.llvm.org/D147285