[PATCH] D154245: [RISCV] Remove legacy TA/TU pseudo distinction for binary instructions

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.cpp:2543
                                   .add(MI.getOperand(0))
+                                  .addReg(MI.getOperand(0).getReg(), RegState::Undef)
                                   .add(MI.getOperand(1))
----------------
reames wrote:
> craig.topper wrote:
> > What happens if we don't use undef here?
> If I remember correctly, you get a verifier error due to a use before definition.
Shouldn't we be using the register from Operand 1 not Operand 0?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154245/new/

https://reviews.llvm.org/D154245