[PATCH] D154545: [llvm-rc] Improve help printouts

Mon Jul 10 09:48:17 PDT 2023

eschwartz added a comment.

In D154545#4475392 <https://reviews.llvm.org/D154545#4475392>, @MaskRay wrote:

> This reminds me of D31199 <https://reviews.llvm.org/D31199> (https://www.sigbus.info/software-compatibility-and-our-own-user-agent-problem).
>
>> Also, since we cannot update the existing configure scripts that are already generated and distributed as part of other programs, even if we improve autoconf, it would take many years until the problem would be resolved.
>
> I think the Meson situation is better since projects don't bundle Meson in their released tarballs... I hope that we file a bug on https://github.com/mesonbuild/meson/issues and fix https://github.com/mesonbuild/meson/blob/1.1.1/mesonbuild/modules/windows.py#L97-L109 instead.

Yes, thank you for this review comment. Unlike autotools, meson actually says "could not determine which type of $THING you are" and then errors out, which in theory means that proper handling gets directly included, so I'm quite happy to be able to detect llvm-rc as LLVM instead of Microsoft. If we ever need to treat them differently, we now can. And it's very easy to push updates to all users.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154545/new/

https://reviews.llvm.org/D154545