[PATCH] D154858: [WIP] [AMDGPU] Add llvm.amdgcn.reduce.add Intrinsic.

[Yashwant Singh via Phabricator via llvm-commits]

yassingh added a comment.

Can add MIR tests.



================
Comment at: llvm/lib/Target/AMDGPU/SILowerReduceAndScanPseudo.cpp:8
+#include "llvm/InitializePasses.h"
+
+using namespace llvm;
----------------
Some description about what the pass will do? Or function comment if this is not implemented as a pass.


================
Comment at: llvm/lib/Target/AMDGPU/SILowerReduceAndScanPseudo.cpp:45-48
+INITIALIZE_PASS_BEGIN(SIExpandReduceAndScanPseudo, DEBUG_TYPE,
+                      "Expand Reduction and Scan Pseudos", false, false)
+INITIALIZE_PASS_END(SIExpandReduceAndScanPseudo, DEBUG_TYPE,
+                    "Expand Reduction and Scan Pseudos", false, false)
----------------
```
INITIALIZE_PASS(SIExpandReduceAndScanPseudo, DEBUG_TYPE,
                      "Expand Reduction and Scan Pseudos", false, false)
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154858/new/

https://reviews.llvm.org/D154858