[PATCH] D154638: Emit a .debug_addr section with dsymutil

[Alexey Lapshin via Phabricator via llvm-commits]

avl added inline comments.


================
Comment at: llvm/lib/DWARFLinker/DWARFLinker.cpp:1996
+                                       SmallVector<uint64_t> &Addrs) const {
+  if (LLVM_UNLIKELY(Options.Update))
+    return;
----------------
one more nit: probably it would  be better to make DWARFLinker::emitDebugAddrSection to be method of DIECloner as everything seems to be DIECloner local.

also, moving check for DWARF version inside emitDebugAddrSection will make DIECloner::cloneAllCompileUnits look simpler:


```
if (DwarfVersion < 5)
  return;
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154638/new/

https://reviews.llvm.org/D154638