[PATCH] D138135: [lld][ELF] Support LoongArch

WÁNG Xuěruì via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 10 04:04:41 PDT 2023


xen0n updated this revision to Diff 538576.
xen0n marked 19 inline comments as done.
xen0n added a comment.

Addressed all review comments:

- Moved the helpers around the `class LoongArch` definition
- Adjusted various comments
  - Toned down some rants
  - Replaced links to archived repo with archive.org snapshots or new refreshed links
  - Other fixes
- Renamed `getLoongArchPageOffset` -> `getLoongArchPageDelta`, fixed its hi32 adjustment logic and added test cases
- Improve diagnostics message for `e_flags` mismatch
- Added tests for `R_LARCH_MARK_LA` and `R_LARCH_{ADD,SUB}{8,16,32,64}`
- `write32le` the break insn
- Set `defaultCommonPageSize` to 16KiB


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138135/new/

https://reviews.llvm.org/D138135

Files:
  lld/ELF/Arch/LoongArch.cpp
  lld/ELF/CMakeLists.txt
  lld/ELF/Driver.cpp
  lld/ELF/InputFiles.cpp
  lld/ELF/InputSection.cpp
  lld/ELF/Relocations.cpp
  lld/ELF/Relocations.h
  lld/ELF/ScriptParser.cpp
  lld/ELF/Target.cpp
  lld/ELF/Target.h
  lld/test/ELF/emulation-loongarch.s
  lld/test/ELF/loongarch-abs64.s
  lld/test/ELF/loongarch-add-sub.s
  lld/test/ELF/loongarch-branch-b16.s
  lld/test/ELF/loongarch-branch-b21.s
  lld/test/ELF/loongarch-branch-b26.s
  lld/test/ELF/loongarch-interlink.test
  lld/test/ELF/loongarch-pc-aligned.s
  lld/test/ELF/loongarch-pcala-lo12-jirl-shared.s
  lld/test/ELF/loongarch-pcala-lo12-jirl.s
  lld/test/ELF/loongarch-plt.s
  lld/test/ELF/loongarch-reloc-pic.s
  lld/test/ELF/loongarch-tls-gd-edge-case.s
  lld/test/ELF/loongarch-tls-gd.s
  lld/test/ELF/loongarch-tls-ie.s
  lld/test/ELF/loongarch-tls-ld.s
  lld/test/ELF/loongarch-tls-le.s
  lld/test/lit.cfg.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138135.538576.patch
Type: text/x-patch
Size: 93876 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230710/48e4bdaf/attachment-0001.bin>


More information about the llvm-commits mailing list