[PATCH] D153260: [RISCV][MC] Implement mapping symbols

Mon Jul 10 02:09:11 PDT 2023

kito-cheng added a subscriber: LiDongjin.
kito-cheng added a comment.

> Any thoughts on whether we should use the `$d`/`$x` (binutils) or `$d.i`/`$x.i` (LLVM AArch64) names?

I don't have strong opinion on which one, but consider the binutils compatibility I would slightly prefer `$d` and `$x` form.

This patch LGTM, however D137417 <https://reviews.llvm.org/D137417> has implement more complete mapping symbol support, I am OK to accept/land this part first and then let D137417 <https://reviews.llvm.org/D137417> to implement the rest part, and actually I am prefer this way since this patch implement some detail more right on creating mapping symbol, but I would like defer the final decision to @asb.

cc @LiDongjin

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153260/new/

https://reviews.llvm.org/D153260