[PATCH] D149367: Emit the CodeView `S_ARMSWITCHTABLE` debug symbol for jump tables

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 2 23:41:36 PDT 2023


efriedma added inline comments.


================
Comment at: llvm/test/CodeGen/Mips/jumptable_labels.ll:1
-; RUN: llc -march=mips < %s | FileCheck %s -check-prefix=O32
-; RUN: llc -march=mips64 -target-abi=n32 < %s | FileCheck %s -check-prefix=N32
-; RUN: llc -march=mips64 < %s | FileCheck %s -check-prefix=N64
+; RUN: llc -mtriple=mips-linux < %s | FileCheck %s -check-prefix=O32
+; RUN: llc -mtriple=mips64-linux -target-abi=n32 < %s | FileCheck %s -check-prefix=N32
----------------
What exactly was going wrong here?  I guess we somehow assume we're emitting CodeView debug info, and then things explode?

Can we make the relevant codepaths check getCodeViewFlag() (which is apparently the canonical way to check according to AsmPrinter::doInitialization())?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149367/new/

https://reviews.llvm.org/D149367



More information about the llvm-commits mailing list