[PATCH] D154306: [InstCombine] Generalise ((x1 ^ y1) | (x2 ^ y2)) == 0 transform to more than two pairs of variables

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 2 12:13:22 PDT 2023


goldstein.w.n added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/icmp-or.ll:415
+  ret i1 %cmp
+}
----------------
Can you 1) split the tests to a seperate patch (so we can see the diff this patch generates).
2) Can you add a few negative tests (maybe where cmp is not against 0, one of the xors has multiuse, where its or->or (invalid), etc...).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154306/new/

https://reviews.llvm.org/D154306



More information about the llvm-commits mailing list