[PATCH] D154217: [AArch64] Use known zero bits when creating BIC

Sun Jul 2 03:20:05 PDT 2023

dmgreen added a comment.

In D154217#4463784 <https://reviews.llvm.org/D154217#4463784>, @RKSimon wrote:

> (sort of related) I noticed issues back when trying to get https://github.com/llvm/llvm-project/issues/53881 fixed that BIC nodes didn't always have matching result / operand types - is that expected?

I see what you mean. We do generate BICi very early - earlier than I would usually think was best.

For the matching types - I'm not sure. I would guess it was just something no-one has run into in the past, it doesn't appear the tablegen will notice that the types are different. It sounds fine to make sure they are the same with an NVCAST, as in d0e2930a21349cacf5cbf528447a590989849438 <https://reviews.llvm.org/rGd0e2930a21349cacf5cbf528447a590989849438>.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154217/new/

https://reviews.llvm.org/D154217